-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: libp2p:bump libp2p version to v0.30 #11434
Conversation
@@ -43,7 +43,7 @@ func (bbr BadBlockReason) String() string { | |||
} | |||
|
|||
func NewBadBlockCache() *BadBlockCache { | |||
cache, err := lru.NewARC[cid.Cid, BadBlockReason](build.BadBlockCacheSize) | |||
cache, err := arc.NewARC[cid.Cid, BadBlockReason](build.BadBlockCacheSize) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really need this for the libp2p upgrade, right ? Do you think we can do this in a separate PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cherry-picked from master, probably best to leave it as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you need this, due to a breaking change in that library introduced in a patch release (see hashicorp/golang-lru#142). I agree that this cherry-pick should be left as is.
e68cda5
to
b78f9ce
Compare
Ok, so, we're simply not downloading the params in those cases. So... I'm backporting a small change to the unit tests to see if it matters. Otherwise... I'm not sure. |
Ok, now both cases should be fixed. |
464514b
to
94787a6
Compare
94787a6
to
c273cbd
Compare
@jennijuju Can we go ahead and merge this ? |
thank you all! |
libp2p v.0.30 has been integrated in lotus and tested with v1.25.0 train for over a month.
Bringing the libp2p dependency more up to date so that the one in the mandatory release doesn't fall behind too much.